Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues found by Spark UT Framework on RapidsMathFunctionsSuite #11142

Open
2 tasks
GaryShen2008 opened this issue Jul 5, 2024 · 0 comments
Open
2 tasks
Labels
bug Something isn't working

Comments

@GaryShen2008
Copy link
Collaborator

GaryShen2008 commented Jul 5, 2024

Describe the bug
Spark UT Framework enabled RapidsMathFunctionsSuite (#10743), with the following test cases explicitly excluded:
It occurs when enabling spark.rapids.sql.expression.Conv=true by #11141

These excluded test cases needs further investigating!!!
Notice: Other test cases in this suite may pass with falling back!

Steps/Code to reproduce bug

  1. Compile everything with mvn -Dbuildver=330 install -DskipTests
  2. Pick a test case name in the above table
  3. Go to RapidsTestSettings and find the line starting with ".exclude" and containing the test case name, comment it out
  4. Run the Suite then you'll see one failed test case. E.g. mvn -nsu -Dbuildver=330 -pl tests -Dsuites="org.apache.spark.sql.rapids.suites.RapidsXXXSuite" test (replace RapidsXXXSuite with the right name in issue header). ALWAYS double check if your suite name coincide with in source code, as it may contain typos!

Expected behavior
The suite can pass without excluding any test case.

@GaryShen2008 GaryShen2008 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jul 5, 2024
@mattahrens mattahrens changed the title [BUG]Issues found by Spark UT Framework on RapidsMathFunctionsSuite [BUG] Issues found by Spark UT Framework on RapidsMathFunctionsSuite Jul 9, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants