-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unshim common classes after spark31x removal #11161
Labels
Comments
Here's a naive approach to identifying candidates for unshimming, which is seeing how many files under sql-plugin/src/main/spark320/ have no other peers after #11159:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
After #11159, there are a number of classes that are under a spark-specific shim directory but are now common across all supported Spark versions.
Describe the solution you'd like
Shimmed classes that are now common should be moved to the standard paths and shim directives removed to simplify the code base.Identify common classes. Base classes or traits that only existed for shim reasons and no longer need to be shims should be removed (e.g.: ShimUnaryExpression and many other classes in TreeNode.scala).
The text was updated successfully, but these errors were encountered: