Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved testing of expressions with empty input #11190

Open
jlowe opened this issue Jul 15, 2024 · 0 comments
Open

Improved testing of expressions with empty input #11190

jlowe opened this issue Jul 15, 2024 · 0 comments
Labels
test Only impacts tests

Comments

@jlowe
Copy link
Member

jlowe commented Jul 15, 2024

#11183 is another case of an issue with properly handling empty input. There needs to be better testing of the empty input corner case for GPU expressions. Note that "empty" here refers to many different things, all of which can be considered "empty" in one way or another:

  • batch with zero rows
  • string column with only null or empty strings (i.e.: data column is empty)
  • column with all nulls (i.e.: empty in the sense that there are no valid data values)
@jlowe jlowe added ? - Needs Triage Need team to review and classify test Only impacts tests labels Jul 15, 2024
@jlowe jlowe changed the title Improved testing of zero-input expressions Improved testing of expressions with empty input Jul 15, 2024
@ttnghia ttnghia added the good first issue Good for newcomers label Jul 16, 2024
@mattahrens mattahrens removed ? - Needs Triage Need team to review and classify good first issue Good for newcomers labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

No branches or pull requests

3 participants