Fix failing test compile for Spark 4.0.0 #11363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
force-pushed
the
fix_400_test_build
branch
from
2861cf6
to
279a085
Compare
|
build |
razajafri
previously approved these changes
Aug 19, 2024
jlowe
added
test
jlowe
reviewed
Aug 19, 2024
| import org.apache.spark.sql.catalyst.expressions.Literal | ||
|
|
||
| object ColumnCreationShim { | ||
| def apply(lit: Literal): Column = new Column(lit) |
There was a problem hiding this comment.
Do we really need to shim this? It appears older Spark versions support the Column.apply method. If so, we could just update the test to use that rather than create a shim.
There was a problem hiding this comment.
I thought I tried that,but I will try it again.
|
build |
|
@razajafri and @jlowe please take another look |
razajafri
approved these changes
Aug 19, 2024
jlowe
approved these changes
Aug 19, 2024
revans2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11350