Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Ensure shims.v2.ParquetCachedBatchSerializer and similar classes are at most package-private #4022

Closed
gerashegalov opened this issue Nov 3, 2021 · 0 comments · Fixed by #4827
Closed

[BUG] Ensure shims.v2.ParquetCachedBatchSerializer and similar classes are at most package-private #4022

gerashegalov opened this issue Nov 3, 2021 · 0 comments · Fixed by #4827
Assignees
@nartal1
Labels
bug Something isn't working P1 Nice to have for release

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Nov 3, 2021 •
edited
Loading

Describe the bug
This is a follow-up issue to #4021 (comment) . We have a few classes that exist merely to be proxied by the publicly documented facade classes. Consider reflecting this in the access level of those classes or their constructors to make sure that the user cannot reference / configure them directly in Apache Spark.
@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify labels Nov 3, 2021
@gerashegalov gerashegalov self-assigned this Nov 3, 2021
@gerashegalov gerashegalov changed the title [BUG] [BUG] Ensure shims.v2.ParquetCachedBatchSerializer and similar classes are at most package-private Nov 3, 2021
@gerashegalov gerashegalov removed their assignment Nov 4, 2021
@Salonijain27 Salonijain27 added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Nov 9, 2021
@nartal1 nartal1 self-assigned this Jan 11, 2022
@nartal1 nartal1 mentioned this issue Jan 19, 2022
Merged
@nartal1 nartal1 mentioned this issue Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nartal1 nartal1

Labels
bug Something isn't working P1 Nice to have for release
Projects
None yet
Milestone
No milestone
3 participants
@gerashegalov @Salonijain27 @nartal1