Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression in CastOpSuite due to cuDF change in parsing NaN #4246

Closed
andygrove opened this issue Dec 1, 2021 · 0 comments · Fixed by #4259
Closed

[BUG] Regression in CastOpSuite due to cuDF change in parsing NaN #4246

andygrove opened this issue Dec 1, 2021 · 0 comments · Fixed by #4259
Assignees
Labels
bug Something isn't working build Related to CI / CD or cleanly building

Comments

@andygrove
Copy link
Contributor

andygrove commented Dec 1, 2021

Describe the bug

cuDF commit rapidsai/cudf@69d5765 appears to have caused a regression in CastOpSuite because cuDF now supports + and - preceding Nan and Inf. There are other changes that impact the plugin as well, such as supporting mixed case (e.g. nAn) and also supporting the word Infinity in full.

- Cast from string to float using hand-picked values *** FAILED ***
  Mismatch casting string [+nAn] to FloatType. CPU: null; GPU: NaN (CastOpSuite.scala:258)

Steps/Code to reproduce bug
Run test using cuDF that includes rapidsai/cudf@69d5765

Expected behavior
Test should pass

Environment details (please complete the following information)
N/A

Additional context
N/A

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Dec 1, 2021
@andygrove andygrove added this to the Nov 30 - Dec 10 milestone Dec 1, 2021
@andygrove andygrove self-assigned this Dec 1, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
2 participants