Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Allow <WindowExec> to partition on Decimal 128 when running on the GPU #4712

Closed
NVnavkumar opened this issue Feb 7, 2022 · 0 comments · Fixed by #4836
Closed

[FEA] Allow <WindowExec> to partition on Decimal 128 when running on the GPU #4712

NVnavkumar opened this issue Feb 7, 2022 · 0 comments · Fixed by #4836
Assignees
Labels
feature request New feature or request

Comments

@NVnavkumar
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, the Spark Rapids plugin limits the types supported for WindowExec calls to common types and Decimal 64. I wish the plugin will support Decimal 128 in the partition spec for Window operations. This relates to the issue #4626 which was closed when StructType support was enabled in #4673.

Describe the solution you'd like
GPU support should be enabled and corresponding test should be added to test for proper support of this feature.

Additional context
libcudf grouped_rolling_window() was tested for __decimal128 support earlier, so this should work in the plugin now.

@NVnavkumar NVnavkumar added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 7, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 8, 2022
@NVnavkumar NVnavkumar self-assigned this Feb 9, 2022
@sameerz sameerz added this to the Feb 14 - Feb 25 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants