Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] remove hasNans for Pivot #5322

Closed
revans2 opened this issue Apr 26, 2022 · 1 comment · Fixed by #5418
Closed

[FEA] remove hasNans for Pivot #5322

revans2 opened this issue Apr 26, 2022 · 1 comment · Fixed by #5418
Assignees
@NVnavkumar
Labels
feature request New feature or request P0 Must have for release
Milestone
May 2 - May 20

Comments

@revans2
Copy link
Collaborator

revans2 commented Apr 26, 2022

Is your feature request related to a problem? Please describe.

Spark is inconsistent in that for pivot NaN != NaN, but for our code it is. This is because we are using a GpuEqualTo internally to check if the value matches the pivot column, and GpuEqualTo has fixes in it to make NaN == NaN. We can fix this with an alternative GpuEqualTo that removes the NaN == NaN fixes.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 26, 2022
@revans2 revans2 mentioned this issue Apr 26, 2022
Closed
8 tasks
@revans2 revans2 added the performance A performance related task/issue label Apr 26, 2022
@revans2
Copy link
Collaborator Author

revans2 commented Apr 26, 2022

I filed https://issues.apache.org/jira/browse/SPARK-39031 for Spark, because it looks inconsistent.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Apr 26, 2022
@NVnavkumar NVnavkumar self-assigned this May 2, 2022
@sameerz sameerz added this to the May 2 - May 20 milestone May 3, 2022
@mattahrens mattahrens added the P0 Must have for release label May 3, 2022
@NVnavkumar NVnavkumar mentioned this issue May 3, 2022
Merged
@mattahrens mattahrens removed the performance A performance related task/issue label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NVnavkumar NVnavkumar

Labels
feature request New feature or request P0 Must have for release
Projects
None yet
Milestone
May 2 - May 20
4 participants
@revans2 @mattahrens @sameerz @NVnavkumar