Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CastChecks.sparkIntegralSig has BINARY in it twice #5726

Closed
tgravescs opened this issue Jun 2, 2022 · 0 comments · Fixed by #5805
Closed

[BUG] CastChecks.sparkIntegralSig has BINARY in it twice #5726

tgravescs opened this issue Jun 2, 2022 · 0 comments · Fixed by #5805
Assignees
@mattahrens
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Jun 6 - Jun 17

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
duplicate BINARY in there, we should remove one

  val sparkIntegralSig: TypeSig = cpuNumeric + BOOLEAN + TIMESTAMP + STRING + BINARY +
      BINARY + GpuTypeShims.additionalTypesIntegralCanCastTo

https://github.com/NVIDIA/spark-rapids/blob/branch-22.06/sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala#L1306
@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jun 2, 2022
@sameerz sameerz added good first issue Good for newcomers and removed ? - Needs Triage Need team to review and classify labels Jun 7, 2022
@mattahrens mattahrens self-assigned this Jun 13, 2022
@mattahrens mattahrens mentioned this issue Jun 13, 2022
Merged
@tgravescs tgravescs added this to the Jun 6 - Jun 17 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattahrens mattahrens

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Jun 6 - Jun 17
Development

Successfully merging a pull request may close this issue.

[Issue 5726] Removing duplicate BINARY keyword mattahrens/spark-rapids
3 participants
@tgravescs @mattahrens @sameerz