Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Set sql.json.read.double.enabled and sql.csv.read.double.enabled to true by default #5813

Closed
sameerz opened this issue Jun 14, 2022 · 0 comments · Fixed by #5935
Closed
Assignees
Labels
feature request New feature or request

Comments

@sameerz
Copy link
Collaborator

sameerz commented Jun 14, 2022

Is your feature request related to a problem? Please describe.
In issue #5323 and PR #5441 we enabled floating point and some double operations by default. We should also enable the following double configurations by default:

spark.rapids.sql.csv.read.double.enabled
spark.rapids.sql.json.read.double.enabled

Describe the solution you'd like
Update our configurations and documentation for the above settings to true.

Describe alternatives you've considered
We've had these operations false by default due to slight variations between CPU and GPU for float and double calculations. Setting these to true should not impact most use cases.

Additional context
N/A

@sameerz sameerz added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 14, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jun 14, 2022
@razajafri razajafri self-assigned this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
2 participants