Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] test_array_intersect failed in databricks 10.4 runtime and Spark 3.3+ #6208

Closed
pxLi opened this issue Aug 3, 2022 · 10 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@pxLi
Copy link
Collaborator

pxLi commented Aug 3, 2022

Describe the bug
related to #5958

[2022-08-03T05:20:04.980Z] FAILED ../../src/main/python/array_test.py::test_array_intersect[Short][INCOMPAT]
[2022-08-03T05:20:04.980Z] FAILED ../../src/main/python/array_test.py::test_array_intersect[Double][INCOMPAT]
[2022-08-03T05:20:04.980Z] FAILED ../../src/main/python/array_test.py::test_array_intersect[Integer][INCOMPAT]
[2022-08-03T05:20:04.980Z] FAILED ../../src/main/python/array_test.py::test_array_intersect[Long][INCOMPAT]
[2022-08-03T05:20:04.980Z] FAILED ../../src/main/python/array_test.py::test_array_intersect[Byte][INCOMPAT]
[2022-08-03T05:20:04.980Z] FAILED ../../src/main/python/array_test.py::test_array_intersect[Float][INCOMPAT]

AssertionError: CPU and GPU list have different lengths at [0, 'sort_array(array_intersect(a, b), true)'] CPU: 1 GPU: 0�

BTW databricks 9.1 runtime works fine.

@pxLi pxLi added bug Something isn't working ? - Needs Triage Need team to review and classify labels Aug 3, 2022
@abellina
Copy link
Collaborator

abellina commented Aug 3, 2022

This also failed in other CI jobs (non databricks) for 22.08 or 22.10.

@NVnavkumar NVnavkumar changed the title [BUG] test_array_intersect failed in databricks 10.4 runtime [BUG] test_array_intersect failed in databricks 10.4 runtime and Spark 3.3+ Aug 3, 2022
@NVnavkumar
Copy link
Collaborator

This also failed in other CI jobs (non databricks) for 22.08 or 22.10.

confirmed the failure is in Spark 3.3.0

@abellina
Copy link
Collaborator

abellina commented Aug 3, 2022

I am seeing a related failure in our Yarn test for test_array_union_before_spark313[Decimal(7,3)]:

cpu = [Decimal('2069.784')], gpu = None

@NVnavkumar
Copy link
Collaborator

This also failed in other CI jobs (non databricks) for 22.08 or 22.10.

confirmed the failure is in Spark 3.3.0

The array_intersect test failure looks like a bug in array_intersect that was introduced in Spark 3.3.0. Here is an example of a test failure with this strange output on the CPU:

Row(a=[-3872, -10423, -24617, -13585, -4093, -23070, -8059, -17080], b=[-17558, -29933, -8524, 30046, -24762, None, 23018, 1300, -23335, 13145, -24768], sort_array(array_intersect(a, b), true)=[], sort_array(array_intersect(b, a), true)=[None])

It probably came from here: apache/spark#34077

I'm guessing Databricks might have pulled in the same "fix"

I will look into the array_union issue but that looks like a separate issue from this one.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Aug 3, 2022
@NVnavkumar
Copy link
Collaborator

NVnavkumar commented Aug 4, 2022

Filed https://issues.apache.org/jira/browse/SPARK-39976

This also failed in other CI jobs (non databricks) for 22.08 or 22.10.

confirmed the failure is in Spark 3.3.0

The array_intersect test failure looks like a bug in array_intersect that was introduced in Spark 3.3.0. Here is an example of a test failure with this strange output on the CPU:

Row(a=[-3872, -10423, -24617, -13585, -4093, -23070, -8059, -17080], b=[-17558, -29933, -8524, 30046, -24762, None, 23018, 1300, -23335, 13145, -24768], sort_array(array_intersect(a, b), true)=[], sort_array(array_intersect(b, a), true)=[None])

It probably came from here: apache/spark#34077

I'm guessing Databricks might have pulled in the same "fix"

I will look into the array_union issue but that looks like a separate issue from this one.

@NVnavkumar
Copy link
Collaborator

Hmm, I replicated the test scenario on the YARN cluster, and all the tests all passed with the same spark version and via YARN and UCX. This looks like some kind of ephemeral failure at this point.

I am seeing a related failure in our Yarn test for test_array_union_before_spark313[Decimal(7,3)]:

cpu = [Decimal('2069.784')], gpu = None

@NVnavkumar
Copy link
Collaborator

This failure occurred again. I'm going to file a new issue to track this one.

Hmm, I replicated the test scenario on the YARN cluster, and all the tests all passed with the same spark version and via YARN and UCX. This looks like some kind of ephemeral failure at this point.

I am seeing a related failure in our Yarn test for test_array_union_before_spark313[Decimal(7,3)]:

cpu = [Decimal('2069.784')], gpu = None

@NVnavkumar
Copy link
Collaborator

Filed #6249 for the array_union failure

This failure occurred again. I'm going to file a new issue to track this one.

Hmm, I replicated the test scenario on the YARN cluster, and all the tests all passed with the same spark version and via YARN and UCX. This looks like some kind of ephemeral failure at this point.

I am seeing a related failure in our Yarn test for test_array_union_before_spark313[Decimal(7,3)]:

cpu = [Decimal('2069.784')], gpu = None

@sameerz
Copy link
Collaborator

sameerz commented Aug 9, 2022

@NVnavkumar please file a follow up issue to revert the changes in #6223 when a fix goes into Spark, and then close this issue.

@NVnavkumar
Copy link
Collaborator

Filed a followup issue #6285 to revert the changes once the fix is made in Apache Spark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants