Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] spark350 shim build failed in mvn-verify github checks and nightly due to dependencies not released #9116

Closed
pxLi opened this issue Aug 28, 2023 · 3 comments · Fixed by #9234
Assignees
Labels
bug Something isn't working build Related to CI / CD or cleanly building

Comments

@pxLi
Copy link
Collaborator

pxLi commented Aug 28, 2023

Describe the bug
spark 3.5.0 RC is still under voting. maven repo does not have required libs for building corresponding shims for now

Let's disable 350 build in nightly to unblock mvn-verify github checks and nightly artifact build,
we can re-enable when available in the future

Steps/Code to reproduce bug
Please provide a list of steps or a code sample to reproduce the issue.
Avoid posting private or sensitive data.

@pxLi pxLi added bug Something isn't working build Related to CI / CD or cleanly building labels Aug 28, 2023
@pxLi pxLi self-assigned this Aug 28, 2023
@pxLi pxLi changed the title [BUG] spark 350 build failed in nightly due to not released [BUG] spark350 shim build failed in mvn-verify github checks and nightly due to dependencies not released Aug 28, 2023
@andygrove
Copy link
Contributor

@pxLi It could be a while before 3.5.0 is released, and we are already finding that PRs can be merged that break the current 3.5.0 build. Could we build the 3.5.0-rc3 artifacts ourselves and publish them to urm so that we can enable pre-merge against 3.5.0-rc3? We can then increment the version if there are future rc releases.

@pxLi
Copy link
Collaborator Author

pxLi commented Aug 31, 2023

@pxLi It could be a while before 3.5.0 is released, and we are already finding that PRs can be merged that break the current 3.5.0 build. Could we build the 3.5.0-rc3 artifacts ourselves and publish them to urm so that we can enable pre-merge against 3.5.0-rc3? We can then increment the version if there are future rc releases.

yes, we could if needed. cc @NvTimLiu can you help deploy a pkgs and bin based on https://github.com/apache/spark/releases/tag/v3.5.0-rc3? So developers could start test against internal maven repo.

As 3.5 RC is still under voting, we will not enable https://github.com/NVIDIA/spark-rapids/blob/branch-23.10/pom.xml#L681-L682 but add a separate pipeline for 3.5 build and testing before the official release

@andygrove please also notify us whenever there is a new RC need to be built, we will need to update all corresponding CICD setups that are targeting RC-old to RC-new, thanks!

@andygrove
Copy link
Contributor

Thanks @pxLi. I will keep you posted about new rc releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants