Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Escape JSON strings in to_json #9514

Closed
andygrove opened this issue Oct 23, 2023 · 0 comments · Fixed by #9612
Closed

[FEA] Escape JSON strings in to_json #9514

andygrove opened this issue Oct 23, 2023 · 0 comments · Fixed by #9612
Assignees
@andygrove
Labels
task Work required that improves the product but is not user facing

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PR #9486 added basic support for to_json, but did not address escaping strings so that we produce valid JSON.

Describe the solution you'd like
Add string escaping and appropriate tests.

Describe alternatives you've considered

Additional context
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 23, 2023
@andygrove andygrove mentioned this issue Oct 23, 2023
Merged
6 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Oct 24, 2023
@andygrove andygrove mentioned this issue Oct 25, 2023
Open
26 tasks
@andygrove andygrove self-assigned this Oct 25, 2023
@andygrove andygrove mentioned this issue Nov 2, 2023
Merged
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape quotes and newlines when converting strings to json format in to_json andygrove/spark-rapids
3 participants
@andygrove @mattahrens @sameerz