Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add libcu++ dependency; initial round of NV_IF_TARGET ports. #1605

Merged
merged 10 commits into from
May 17, 2022
Merged

Add libcu++ dependency; initial round of NV_IF_TARGET ports. #1605

merged 10 commits into from
May 17, 2022

Commits on May 16, 2022

  1. Add libcudacxx submodule, initialized to version 1.8.0.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    97e63f9 View commit details
    Browse the repository at this point in the history

  2. Style fixes for thrust-config.cmake.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    b19385a View commit details
    Browse the repository at this point in the history

  3. Bump CUB for NV_IF_TARGET refactor.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    807e9e0 View commit details
    Browse the repository at this point in the history

  4. Remove thrust_set_libcudacxx_target function from CMake user API. 

    There's no way for a user to meaningfully use this, since libcudacxx
is a required dependency. It is checked during the initial
`find_package(Thrust)` call, before the user would have access to
Thrust's CMake API.

Updated the CMake README.md with instructions for using an explicit
libcudacxx target.
    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    539c9fa View commit details
    Browse the repository at this point in the history

  5. Remove checks for obsolete architectures.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    9e4f0a3 View commit details
    Browse the repository at this point in the history

  6. Refactor to use NV_IF_TARGET.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    3ea8940 View commit details
    Browse the repository at this point in the history

  7. Remove unreachable code.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    fdcd8e1 View commit details
    Browse the repository at this point in the history

  8. Initialize members in cuda_optional detail class.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    59a72c0 View commit details
    Browse the repository at this point in the history

  9. Fix some new and exciting exec_space [subobject] warnings.

    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    dd561bf View commit details
    Browse the repository at this point in the history

  10. Fix issues in testing/allocator.cu. 

    - The `g_state` flag wasn't reset between executions.
- The `destroy` method was being invoke in the current host system,
  not the system that owned the allocated memory (always cpp).
  This broke on MSVC's OpenMP implementation, where it seemed to be
  asserting the `g_state` flag before it was updated by `destroy`.
  This only happened on MSVC when host system = OMP, and appears to
  be a bug/miscompile in MSVC (repro'd on 2019). Fixed by explicitly
  tagging the allocator system to cpp.
- Added check that `destroy` is not invoked on empty vectors.
    @alliepiper
    alliepiper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4cdf6de View commit details
    Browse the repository at this point in the history