Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load customized dataset #37

Open
Jianhao-zheng opened this issue Aug 14, 2024 · 0 comments
Open

Load customized dataset #37

Jianhao-zheng opened this issue Aug 14, 2024 · 0 comments

Comments

@Jianhao-zheng
Copy link

Hi, I tried to run CF-GS on my customized dataset and I found there may be a potential bug in "trainer/trainer.py". It appears between line 276-280:

            if min(width, height) > 1000:
                width = width // 2
                height = height // 2
            
            intr_mat[:2, :] /= 2

I think "intr_mat[:2, :] /= 2" should also go under the if condition. I think the logic is if the images are too big, you resize the resolution by half and modify the intrinsic accordingly. But the current code divide the intrinsic by half even if the image has low resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant