Library to Ingest: weekly OpenData templates #1289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
=======================================
Coverage 69.83% 69.83%
=======================================
Files 110 110
Lines 5900 5900
Branches 659 659
=======================================
Hits 4120 4120
Misses 1648 1648
Partials 132 132 ☔ View full report in Codecov by Sentry. |
sf-dcp
commented
Dec 2, 2024
| - name: most_curre | ||
| - name: status | ||
| - name: wkb_geometry | ||
|
|
There was a problem hiding this comment.
latitude & longitude columns no longer exist at the source - remove. These columns are actually not used in the build, so no impact. Added wkb_geometry bc it's actually expected.
sf-dcp
force-pushed
the
sf-ingest-open-data-1
branch
2 times, most recently
from
db1f5c0 to
d0a335a
Compare
Remove lon and lat columns from `lpc_landmarks` source in GFT - no longer exist at the source. Note, these columns are not used in GFT build.
sf-dcp
force-pushed
the
sf-ingest-open-data-1
branch
from
d0a335a to
529f0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1247. Reports for specific datasets can be found there.