Better UIImage Support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew. Previously, these public methods only took NSData, which would mean converting regular UIImages into data and later back into images – which is both more complex logic and less performant. Additionally, UIImage, as the more common case than an animated image, should conceptually be a first-class citizen and the public APIs, in my opinion, now reflect that status.
…priately. Before it considered everything data and was making unnecessary (and metadata-lossy) conversions of UIImages to PNG data.
|
+1, this would fix some speed issues we're having |
|
Proposal accepted, please fix conflicts and add tests. |
…-proposal # Conflicts: # Pod/Classes/ios/NYTScalingImageView.h
|
Okay. I've resolved the merge conflicts and added the tests. A couple notes:
|
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a proposal to improve the public API of
NYTScalingImageViewand the internal code of both that class andNYTPhotoViewerto elevate using normalUIImages to a first-class behavior after the addition of animated GIF support.Currently, on develop,
NYTScalingImageViewonly has APIs that supportNSData, which means thatNYTPhotoobjects that only contain a non-animatedUIImageare shoehorned into an API that then causesUIImagesto be converted to data (a potentially metadata-lossy conversion) in order to call these APIs, and then back toUIImageobjects internally in those methods. This is both less performant and more complex than an API that treatsUIImageandNSDataequally, as they are in theNYTPhotoprotocol. This pull request adds that API and removes the need for converting images to data and then converting that data back to images again.Additionally, the docs for these new APIs that take
NSDatawere never updated to reflect that fact, so I have also updated those in this pull request.