[Feature] Support native dismissViewControllerAnimated:completion: method instead of custom one. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of custom one.
|
This looks great, @DenHeadless. There are a few things we'd like to tweak, but we're happy to merge and then I'll make a couple small changes in a followup PR. |
cdzombak
added a commit
that referenced
this pull request
Jan 13, 2016
[Feature] Support native dismissViewControllerAnimated:completion: method instead of custom one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
It seems that default dismissViewControllerAnimated:completion: does not work, because it's interactive.
Correct way to handle this is to make transition interactive only when user starts panning, and disable interactivity by default.
I believe this PR closes #109 as well as #72 and #96. It also allows to call correct delegate callbacks and notifications when dismissing controller.
What do you guys think, am I missing something?
/cc @cdzombak