Send delegate messages for all user-initiated dismissals

[cdzombak]

• Refactor how dismissals are managed, to allow disambiguating user-initiated and programmatic dismissals for determination of whether to send delegate messages, without tracking an additional bit of state.
• 16bd3c0 should've been covered in Removed Redundant Swift Tests #128 , but I just now noticed it
• Other commits in this PR are documentation improvements around this behavior, and minor style improvements.

Closes #134.

[bcapps]

Could you potentially eliminate this intermediate state if both doneButtonTapped: and didPanWithGestureRecognizer called through to a common method, hypothetically something like dismissViewControllerAnimated:isUserInitiated:completion:, passing YES for isUserInitiated, while dismissViewControllerAnimated:completion: calls through to the common method with NO?

[cdzombak]

@bcapps 💯

[soundsokay]

👍 save for the (nice to have) expanded unit test coverage noted in the comment in eff4f08

[cdzombak]

Currently this test is failing, though setting a breakpoint in -dismissViewControllerAnimated:userInitiated:completion: tells me that that method ​_is_​ being called, with those values (YES, NO, nil). So…what am I missing?

[bcapps]

Although the code looks right, the error message seems to imply that it's expecting (YES,YES,nil) instead of what you intended.

[cdzombak]

Although the code looks right, the error message seems to imply that it's expecting (YES,YES,nil) instead of what you intended.

Hm, I must've skimmed over that. I've been looking at OCMock errors too long this morning.

…blowing away DerivedData doesn't fix this (ie. it's not left from a previously-cached build), so I'm at a bit of a loss.

[cdzombak]

922bdb0 makes no difference.

[soundsokay]

👍