Clarify how title-text delegate method is intended to be used #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps clarify that this delegate method is intended to provide information about the user’s progress in a set of photos, not about a photo itself.
This helps clarify that this delegate method is intended to provide information about the user’s progress in a set of photos, not about a photo itself.
This helps clarify exactly what work can be skipped when we’re only showing one photo.
|
👍 |
dzlobin
added a commit
that referenced
this pull request
Feb 1, 2016
Clarify how title-text delegate method is intended to be used
| * Returns a string to display as the title of a photo. | ||
| * Returns a string to display as the title in the navigation-bar area for a photo. | ||
| * | ||
| * This small area of the screen is not intended to display a caption or similar information about the photo itself. (NYTPhotoViewer is designed to provide this information in the capton view, and as such the `NYTPhoto` protocol provides properties for the title, summary, and credit for each photo.) Instead, consider using this delegate method to customize how your app displays the user's progress through a set of photos. |
There was a problem hiding this comment.
information in the capton view
Typo here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup from #142, this PR proposes a small API change and further documentation to clarify how our team believes this new avenue for customization should be used.
I've also slightly simplified some of the logic behind it and provided an example implementation in the Example app.