Documentation and clarification around NYTPhoto.image vs .imageData #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several other places in the code (listed below) where we check for `imageData` regardless of whether the library was built with animated GIF support; this simply brings behavioral parity to these checks to ensure consistent behavior. - in `NYTPhotosViewController` dismissal logic: https://github.com/NYTimes/NYTPhotoViewer/blob/ef85465839c6e47715ef4016c7436ca8415106d1/Pod/Classes/ios/NYTPhotosViewController.m#L363 - in `NYTPhotoViewController` initializer: https://github.com/NYTimes/NYTPhotoViewer/blob/ef85465839c6e47715ef4016c7436ca8415106d1/Pod/Classes/ios/NYTPhotoViewController.m#L98 - in `-[NYTPhotoViewController updateImage:imageData:]`: https://github.com/NYTimes/NYTPhotoViewer/blob/ef85465839c6e47715ef4016c7436ca8415106d1/Pod/Classes/ios/NYTPhotoViewController.m#L135
|
The warning introduced in 34f45a1 looks like this:
|
|
Do you think that it might also be worth renaming |
@bcapps probably, but as that's a breaking API change it'll have to wait for v2. I'll file a separate issue under that milestone as a reminder, in the same vein as #136. |
|
👍 |
|
👍 |
cdzombak
added a commit
that referenced
this pull request
Feb 2, 2016
Documentation and clarification around NYTPhoto.image vs .imageData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly followup from the changes in #106.
NYTPhotoaboutimagevsimageDataimageDataproperty but animated GIF support is compiled out (since that really makes no sense, as discussed in Better UIImage Support #106)