Bugfixes: bounds checks, don't retain data source #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2017 17:30
This would lead too easily to difficult-to-manage retain cycles.
|
👍 |
shagedorn
pushed a commit
to iosphere/NYTPhotoViewer
that referenced
this pull request
Jul 25, 2017
* develop: (50 commits) Add initial contributing guidelines style: remove unnecessary Array initializer call Remove no-longer-necessary bounds check in Swift Example style: make Swift-Example style tweaks, requested by @Veronique Add README documentation on Example project dependency management Update Changelog for nytimes#227 fix: PhotosViewController shouldn’t retain its data source fix: add bounds checks before asking data source for a photo Reimplement Swift example fix: include single photo data source in umbrella header Use more modern `nullable` instead of `_Nullable` example: Improve caption for photo with a loading spinner example: Improve data-source-swap demo example: Use a more obvious demo for custom maximum zoom scale docs: add missing copyright in headers Update LICENSE to specify (c) through 2017 docs: add this feature to CHANGELOG docs: clarify how NYTPhoto equality is determined fix: use proper equality checks style: correct spacing in Example ViewController ...
benguild
pushed a commit
to benguild/NYTPhotoViewer
that referenced
this pull request
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs I found while rewriting the Swift example (#223):
PhotosViewControllershould not retain its data source. This will lead trivially easily to retain cycles which would be difficult to manage.PhotosViewControllerwas asking its data source for nonsensical bounds when scrolling from the first photo. I've added a check to avoid that, and while I was there I added a check to prevent the viewer from skipping back to the first photo when the data source returnsNSNotFoundfor a photo.