Rename …didDisplayPhoto… to …didNavigateToPhoto… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This more closely reflects that this delegate method/notification is tightly tied to user interactions. closes #42
|
Solid, but sadly a breaking change. :( |
yes, this would require a new major version. I considered deprecating the current API and adding the new one, which could only require a new minor version, but that seemed like too much complexity. |
Agreed. Totally agree that this should probably be merged. |
|
@Twigz @steve-matthews thoughts? |
|
I'm a 👍 |
Twigz
added a commit
that referenced
this pull request
May 1, 2015
Rename …didDisplayPhoto… to …didNavigateToPhoto…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more closely reflects that this delegate method/notification is tightly tied to user interactions.
I'm taking the viewpoint here that #42 is a naming "bug", not a behavior bug as such, since the method's docs say:
closes #42