Issue 28 nytphotosviewcontroller crashes on tapping share button on ipad #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - (void)displayActivityViewController:(UIActivityViewController *)controller animated:(BOOL)animated { | ||
|
|
||
| if(UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone) { |
There was a problem hiding this comment.
Can you update the if statements in this method to have whitespace between the if and the ( to conform to the Times Objective-C Style Guide?
Thanks!
heikkihautala
force-pushed
the
issue-28-nytphotosviewcontroller-crashes-on-tapping-share-button-on-ipad
branch
from
f650c00
to
c147cb7
Compare
|
Thanks @Twigz, white spaces fixed :) |
| } | ||
| else { | ||
| // iOS 7 | ||
| _activityPopoverController = [[UIPopoverController alloc] initWithContentViewController:controller]; |
There was a problem hiding this comment.
@heikkihautala is there a particular reason you're using the instance variable here rather than using self.activityPopoverController as a property?
heikkihautala
force-pushed
the
issue-28-nytphotosviewcontroller-crashes-on-tapping-share-button-on-ipad
branch
from
c147cb7
to
a491d10
Compare
heikkihautala
force-pushed
the
issue-28-nytphotosviewcontroller-crashes-on-tapping-share-button-on-ipad
branch
from
a491d10
to
1d00753
Compare
|
Good points @bcapps! PR updated :) |
|
This looks good to us. Thanks, @heikkihautala! closes #28. |
cdzombak
added a commit
that referenced
this pull request
May 13, 2015
…oller-crashes-on-tapping-share-button-on-ipad Issue 28 nytphotosviewcontroller crashes on tapping share button on ipad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.