Xcode 7 fixes & modernization #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,21 +20,21 @@ class NYTPhotosOverlayViewTests: XCTestCase { | |||
| let overlayView = NYTPhotosOverlayView() | |||
| let leftBarButtonItem = UIBarButtonItem(barButtonSystemItem: UIBarButtonSystemItem.Done, target: nil, action: nil) | |||
| overlayView.leftBarButtonItem = leftBarButtonItem | |||
| XCTAssert(leftBarButtonItem == overlayView.navigationBar.items.first?.leftBarButtonItem) | |||
| XCTAssert(leftBarButtonItem == overlayView.navigationBar.items!.first?.leftBarButtonItem) | |||
There was a problem hiding this comment.
should we force unwrap here? Will this crash the tests if items is nil? I am thinking maybe we can change the ! to a ? so the test would just fail instead of crash if items is nil.
FYI this swift business is new to me so let me know if I am reading this wrong or making incorrect assumptions.
There was a problem hiding this comment.
My thinking here was, it's a test, if it crashes so be it, that's still a failure. But maybe we ought to just let nil come through and have the assertion fail. Will send an updated PR.
|
@cdzombak looks good: merging. In your next PR if you think this makes sense would u mind addressing? #76 (comment) |
steve-matthews
added a commit
that referenced
this pull request
Oct 14, 2015
Xcode 7 fixes & modernization
This was referenced Oct 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accepts Xcode 7-recommend build settings changes and fixes problems revealed by some new warnings that are enabled by default in Xcode 7.
Other changes include:
Coming in a later PR: I need this PR as a foundation to keep working, but in my next PR I will address test failures introduced by dc75d98 .