Use scrolling UITextView for captions #88

cdzombak · 2015-10-30T19:05:05Z

closes #45

Still todo

Fix shadow view position: layer's bounds after last -layoutSubviews call to the caption view have the wrong height. This applies to iOS 8 only.
Resolve Auto Layout warnings printed on presentation. This applies to iOS 9 only.
Consider pinning the text view to full width and using contentInset or textContainerInset instead of horizontal padding.

This allows scrolling.

…ltin

Need some sort of width hint to provide an intrinsic size.

This maintains compatibility with custom caption view classes

This simplifies our sizing calculation and layout code.

cdzombak · 2015-11-02T20:44:29Z

See if we can allow panning the page VC left/right over a scrolling caption view.

This is going to require more though to complete in a clean way, keeping the rest of the library away from knowing about caption views (since they're replaceable).

grantjbutler · 2015-11-02T20:52:52Z

Pod/Classes/ios/NYTPhotosOverlayView.m

@@ -49,6 +50,10 @@ - (void)layoutSubviews {
    }];

    [super layoutSubviews];
+
+    if ([self.captionView respondsToSelector:@selector(setPreferredMaxLayoutWidth:)]) {


Should this be [self.captionView conformsToProtocol:@protocol(NYTPhotoCaptionViewLayoutWidthHinting)]?

I'm not sure. Here are some arguments for and against changing to conformsToProtocol:

for

the current code carries implicit knowledge of what's in the NYTPhotoCaptionViewLayoutWidthHinting protocol, spilled across 2 lines (though a change to the protocol would still cause a compiler warning)

we should check exactly what we're casting to, before casting

against

what we really care about is whether we can set preferredMaxLayoutWidth, and with this approach certain classes (UILabel) get correct behavior for free. (the cast is practically a detail to satisfy the compiler, though a change to the protocol would still cause a compiler warning)

conformsToProtocol: requires a global runtime lock; respondsToSelector: does not

even if we check that it conforms to the protocol, the code still carries implicit knowledge about what methods are in the protocol because we still have to cast before sending the message

I asked because I assumed that was the point of adding the protocol in the first place. If you're just interested in the caption view responding to setPreferredMaxLayoutWidth:, what's the point of the protocol? You could just as easily cast to id and use the method, not the property, to silence any compiler warnings.

If you're just interested in the caption view responding to setPreferredMaxLayoutWidth:, what's the point of the protocol?

So that I have something to cast to on the next line: (id<NYTPhotoCaptionViewLayoutWidthHinting>)

I updated my comment with this line after you posted yours:

You could just as easily cast to id and use the method, not the property, to silence any compiler warnings.

That's really the best answer for "why check respondsToSelector: instead of conformsToProtocol:?" Just that the former requires the runtime lock while doing 60fps UI work.

Whereas respondsToSelector: doesn't lock anything:

respondsToSelector: itself doesn't lock anything, but lookUpImpOrForward (which is called by lookUpImpOrNil) does get a runtime lock.

respondsToSelector: itself doesn't lock anything, but lookUpImpOrForward (which is called by lookUpImpOrNil) does get a runtime lock.

well, I'll be! the comment on that function doesn't include a note about locking…I guess I should send a PR :)

That said, would something like that be considered an implementation detail if it's not mentioned in any documentation apart from the source code?

This is all implementation detail! And I think I am sufficiently convinced not to micro-optimize this for now (though I suspect that this cache lookup will almost always succeed); see 162e0ba

steve-matthews · 2015-11-02T23:14:02Z

Example/NYTPhotoViewer/NYTViewController.m

@@ -11,6 +11,7 @@
 #import "NYTExamplePhoto.h"

 static const NSUInteger NYTViewControllerCustomEverythingPhotoIndex = 1;
+static const NSUInteger NYTViewControllerLongCaptionPhotoIndex = 2;
 static const NSUInteger NYTViewControllerDefaultLoadingSpinnerPhotoIndex = 3;
 static const NSUInteger NYTViewControllerNoReferenceViewPhotoIndex = 4;
 static const NSUInteger NYTViewControllerCustomMaxZoomScalePhotoIndex = 5;


just curious as to why not just make these static ints an enum.

¯_(ツ)_/¯ they were static ints before, and slowly we've added a few more special cases.

per feedback https://github.com/NYTimes/NYTPhotoViewer/pull/88/files#r43697798

cdzombak · 2016-01-04T19:42:06Z

I've resolved merge conflicts in 5d1a27d

cdzombak · 2016-01-07T22:12:06Z

I've resolved merge conflicts in 0cd6a1e

Use scrolling UITextView for captions

cdzombak · 2016-01-08T03:49:02Z

✨

cdzombak added 11 commits October 30, 2015 12:46

Add an example photo with extremely long caption

0bdbe40

Attach font sizes to captions in Example app

b1319cd

Use UITextView for NYTPhotoCaptionView

0fdaf3a

This allows scrolling.

Reduce caption margins since UITextView has line fragment padding bui…

389b562

…ltin

First pass at PhotoCaptionView intrinsic content size with a text view

1e825d9

Second pass at calculating caption content size

cefbcb3

Need some sort of width hint to provide an intrinsic size.

Give caption views a hint about their layout widths

294848f

Extract NYTPhotoCaptionViewLayoutWidthHinting protocol to its own file

ee159d3

pod install in Example app

3070605

Use relative, not hardcoded, max caption height

a9e7aa5

Add caption max height constraint from _our_ caption class

bee2378

This maintains compatibility with custom caption view classes

cdzombak self-assigned this Oct 30, 2015

cdzombak added 9 commits November 2, 2015 14:52

Mark PhotoCaptionView as requiring constraint-based layout

055ca60

PhotoCaptionView takes only 30% of height

e7230df

Resolve iOS 8.x gradient-layer layout bug

f88bad8

Eliminate added vertical padding on PhotoCaptionView

f29731d

Merge remote-tracking branch 'origin/develop' into cdz/scroll-captions

11b47eb

Standardize PhotoCaptionView.preferredMaxLayoutWidth on setting it

81c1014

Use textContainerInsets for padding PhotoCaptionView

20eca18

This simplifies our sizing calculation and layout code.

[minor] update forgotten header comments

a5a5441

[minor] fix misspelled constant in PhotosViewController

7c59992

cdzombak changed the title ~~[WIP] Use scrolling UITextView for captions~~ Use scrolling UITextView for captions Nov 2, 2015

cdzombak removed their assignment Nov 2, 2015

grantjbutler reviewed Nov 2, 2015
View reviewed changes

Check for protocol conformance, not a specific method, before casting

162e0ba

steve-matthews reviewed Nov 2, 2015
View reviewed changes

cdzombak added 2 commits November 3, 2015 09:23

Use an enum for example photo indices

4acbeeb

per feedback https://github.com/NYTimes/NYTPhotoViewer/pull/88/files#r43697798

Merge remote-tracking branch 'origin/develop' into cdz/scroll-captions

5d1a27d

Resolve warning about unhandled case in Example project

211d897

Merge remote-tracking branch 'origin/develop' into cdz/scroll-captions

0cd6a1e

steve-matthews added a commit that referenced this pull request Jan 8, 2016

Merge pull request #88 from NYTimes/cdz/scroll-captions

938968d

Use scrolling UITextView for captions

steve-matthews merged commit 938968d into develop Jan 8, 2016

cdzombak deleted the cdz/scroll-captions branch January 8, 2016 03:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use scrolling UITextView for captions #88

Use scrolling UITextView for captions #88

cdzombak commented Oct 30, 2015

cdzombak commented Nov 2, 2015

grantjbutler Nov 2, 2015

cdzombak Nov 2, 2015

grantjbutler Nov 2, 2015

cdzombak Nov 2, 2015

grantjbutler Nov 2, 2015

cdzombak Nov 2, 2015

grantjbutler Nov 2, 2015

cdzombak Nov 2, 2015

grantjbutler Nov 2, 2015

cdzombak Nov 2, 2015

steve-matthews Nov 2, 2015

cdzombak Nov 3, 2015

cdzombak commented Jan 4, 2016

cdzombak commented Jan 7, 2016

cdzombak commented Jan 8, 2016

Use scrolling UITextView for captions #88

Use scrolling UITextView for captions #88

Conversation

cdzombak commented Oct 30, 2015

Still todo

cdzombak commented Nov 2, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

for

against

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cdzombak commented Jan 4, 2016

cdzombak commented Jan 7, 2016

cdzombak commented Jan 8, 2016