Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misplacing view position while zoom transition. #89

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Fix misplacing view position while zoom transition. #89

merged 1 commit into from
Nov 3, 2015

Conversation

iziz
Copy link

@iziz iziz commented Nov 2, 2015

(AS-IS) set to center -> Update zoom scale

(TO-BE) Update zoom scale -> set to center

@cdzombak
Copy link
Contributor

cdzombak commented Nov 2, 2015

Fix misplacing view position while zoom transition

@iziz could you please clarify exactly what this fix addresses, or maybe provide an animation illustrating the problem?

@cdzombak cdzombak self-assigned this Nov 2, 2015
@iziz
Copy link
Author

iziz commented Nov 3, 2015

Ah!!
It will occur, when startView's image size is not match with endingView's image size.
(thumbnail image -> async download full image)

cdzombak added a commit that referenced this pull request Nov 3, 2015
@cdzombak
Merge pull request #89 from iziz/develop
1bcc3f8 
Fix misplacing view position while zoom transition.
@cdzombak cdzombak merged commit 1bcc3f8 into nytimes:develop Nov 3, 2015
@cdzombak
Copy link
Contributor

cdzombak commented Nov 3, 2015

thanks for your contribution, @iziz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdzombak cdzombak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iziz @cdzombak