Match imports by file ext in Jest test config #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianvmodesto
changed the title
tizmagik
approved these changes
Jan 11, 2017
delambo
added a commit
that referenced
this pull request
Feb 7, 2017
* master: Fix typo (#379) kyt-cli version bump (#376) updates the kyt-cli version (#370) fixes cli starter kyt path bug (#369) Adds prep for 0.4.0 release candidate (#368) Adding identity object property; fixing preprocessor bug (#367) Adds yarn support with npm fallback (#270) Fix typo (#366) Match imports by file ext in Jest test config (#363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#362
The regex in the Jest
moduleNameMapperisn't matching modules that are prefixed with Webpack loaders (e.g.import 'styles!css!./styles.css) , so modules aren't being stubbed.Changes
Updated the regex to only match modules by file extension.
cc @tizmagik