-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove hardcoded FirmwareImageType
in favor of a plain string
#80
Comments
I'd like to keep the firmware types restricted to a set of well-known values (since there will be at most only a few). If you want to add internal information to describe a firmware variant, I think adding a new free-form field to the JSON like NabuCasa/silabs-firmware-builder#82 will rename all of the firmware types to be more generic (e.g. |
It prevents the use of other firmware types like the RCP blehci, even though the flasher should support it just fine out-of-the-box. Also the error is very generic ( |
Yeah, I'll definitely change it to a warning instead of an error. Just going forward, I think we should stick to a standard firmware type instead of tweaking it per firmware variant. |
Fixed by #81. |
universal-silabs-flasher/universal_silabs_flasher/firmware.py
Line 111 in 2e302a2
This line hard-fails if the in-file firmware type is anything other than the values in
FirmwareImageType
, preventing flashing of otherwise perfectly valid, and supported firmware.Since that metadata is added by firmware builder manifest, it should not prevent the use of custom values, or even more "official" values that are not yet entered in the enum (forcing update of flasher).
The text was updated successfully, but these errors were encountered: