Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running CLI with join column for target data #356

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

michael-nml
Copy link
Collaborator

This PR fixes running the CLI with a join column specified for the target dataset.

For example:

input:
  reference_data:
    path: https://github.com/NannyML/nannyml/raw/main/nannyml/datasets/data/regression_synthetic_reference.csv
  analysis_data:
    path: https://github.com/NannyML/nannyml/raw/main/nannyml/datasets/data/regression_synthetic_analysis.csv
  target_data:
    path: https://github.com/NannyML/nannyml/raw/main/nannyml/datasets/data/regression_synthetic_analysis_targets.csv
    join_column: id

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2af5e7b) 80.23% compared to head (9c661c4) 80.23%.

Files Patch % Lines
nannyml/runner.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files         107      107           
  Lines        7953     7953           
  Branches     1451     1451           
=======================================
  Hits         6381     6381           
  Misses       1249     1249           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters merged commit 718a898 into main Feb 2, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants