Fix plotting confidence bands with gaps #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plotly doesn't correctly handle fills with gaps. This is an issue for confidence bands as they are being plotted currently. Work around is to tell Plotly to fill the gaps, which causes correct rendering. Unfortunately it does fill the gap, but this is the easiest work around for now. See plotly/plotly.js#2736 for context.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 78.92% 78.95% +0.02%
==========================================
Files 107 107
Lines 8086 8086
Branches 1290 1467 +177
==========================================
+ Hits 6382 6384 +2
+ Misses 1364 1363 -1
+ Partials 340 339 -1 ☔ View full report in Codecov by Sentry. |
|
Example plots for reference Before fix
After fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotly doesn't correctly handle fills with gaps. This is an issue for confidence bands as they are being plotted currently. Work around is to tell Plotly to fill the gaps, which causes correct rendering. Unfortunately it does fill the gap, but this is the easiest work around for now.
See plotly/plotly.js#2736 for context.