Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PCA #385

Merged
merged 2 commits into from
May 6, 2024
Merged

Refactor PCA #385

merged 2 commits into from
May 6, 2024

Conversation

nikml
Copy link
Contributor

@nikml nikml commented May 3, 2024

  • refactor pca for speed and code quality improvements

@nikml nikml requested a review from nnansters as a code owner May 3, 2024 15:54
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.59%. Comparing base (57d4148) to head (4fc6e79).

Files Patch % Lines
...ift/multivariate/data_reconstruction/calculator.py 89.47% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   78.67%   78.59%   -0.08%     
==========================================
  Files         110      110              
  Lines        8567     8565       -2     
  Branches     1523     1519       -4     
==========================================
- Hits         6740     6732       -8     
- Misses       1468     1474       +6     
  Partials      359      359              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters
Copy link
Contributor

Nice one buddy! 🏅

@nnansters nnansters merged commit 540f82b into main May 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants