Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Synchronize some editor functionalities #137

Closed
jspenguin2017 opened this issue Mar 17, 2018 · 3 comments
Closed

Synchronize some editor functionalities #137

jspenguin2017 opened this issue Mar 17, 2018 · 3 comments
Labels
archived This thread was archived, open new issues for similar problems. fixed
Milestone

Comments

@jspenguin2017
Copy link
Member

jspenguin2017 commented Mar 17, 2018

I started Nano expecting gorhill to never add an IDE to uBO, but it happened, and it was done pretty well. 3 months ago, Nano was clearly superior when it comes to crafting filter rules, but now uBO is catching up real fast, and we are falling behind. Although we might need to re-think our future, we'll finish pulling recent changes in the meantime.

My filters - Upstream changes rejected for now, I will implement these functionalities:

  • (Done) Ctrl + S for saving
  • Proper last line break handling (optional)
  • Clear undo history on load (optional)

My rules - Upstream changes accepted

Whitelist - Upstream changes accepted, I will (re)implement these functionalities:

  • Warn suspicious RegExp rule
  • Clean up dead background code

Assets Viewer - Upstream changes rejected

@jspenguin2017
Copy link
Member Author

I'm really busy these weeks, hopefully I can get them done by next week.

@jspenguin2017 jspenguin2017 added this to the v1.0.1 milestone Mar 17, 2018
@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Apr 7, 2018

Looks like we'll need to rebase... Anything else should I push to upstream before I do that?...

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Aug 5, 2018

Most are sorted out.
The rest are tracked in #1 .

@github-actions github-actions bot added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This thread was archived, open new issues for similar problems. fixed
Projects
None yet
Development

No branches or pull requests

1 participant