Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Revisit the way the new popup contracts and expands #334

Closed
jspenguin2017 opened this issue May 16, 2020 · 1 comment
Closed

Revisit the way the new popup contracts and expands #334

jspenguin2017 opened this issue May 16, 2020 · 1 comment
Labels
archived This thread was archived, open new issues for similar problems. fixed

Comments

@jspenguin2017
Copy link
Member

jspenguin2017 commented May 16, 2020

I don't want it to contract and expand 6 times, but it does make sense for some of the buttons to be hidden by default.

Probably 3 different states:

  • Top toolbar and firewall panel both hidden
  • Top toolbar shown but firewall panel hidden
  • Top toolbar and firewall panel both shown
@jspenguin2017
Copy link
Member Author

jspenguin2017 commented May 16, 2020

Or maybe we can simply change the default value of popupPanelLockedSections, that's probably a lot simpler than the current patch that completely change the contract and expand logic.

The arrows on the More and Less buttons can probably be restored too.

Also don't forget to add settings migration.

@github-actions github-actions bot added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This thread was archived, open new issues for similar problems. fixed
Projects
None yet
Development

No branches or pull requests

1 participant