Add progress bar for notebooks #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to make this work in quiet mode, I think? |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Add progress bar for notebooks * Update progress bar in quiet mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the idea of using
_repr_markdown_and__repr__to adapt the display to notebooks and the terminal won't work because IPython will always call__repr__in addition to_repr_markdown_. This PR adds a progress bar for notebooks, but still prints the same text it was printing before. It looks like this:Including the text kind of defeats the purpose of the progress bar, but I'm not sure we can do much better until there is a reliable way to detect if we're running in a notebook.
@stevengj @oskooi