fix bug in tick assignment for get_array_metadata #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2021
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1484.
#1456 changed the default behavior of
get_array_metadataby collapsing all empty directions of the array slice. This change unfortunately created a bug in the tick assignment of the collapsed directions: e.g., for a 1d slice withmp.Volume(center=mp.Vector3(1.5,0),size=mp.Vector3(0,5.5)), thexticks were being set to0which is incorrect and are now set to1.5.A separate PR will add a test for the
FourierFieldsclass of the adjoint solver which also includes a test for this feature ofget_array_metadata(which had been missing).