Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate gradient with objective functions containing Fourier arguments #1491

Closed
smartalecH opened this issue Feb 3, 2021 · 1 comment

Comments

@smartalecH
Copy link
Collaborator

As usual, meep interpolates the DFT fields from the yee grid. This interpolation introduces an error in the adjoint gradient calculation unless we backpropagate through it (just multiply by the transpose of the interpolation). We haven't yet implemented this, but probably should (when we have time and need the feature).

Ironically, the eigenmode arguments, which are much more complicated (and technically a function of the Fourier fields...) don't have this issue because we already took this into account (see #1270).

@smartalecH
Copy link
Collaborator Author

#1959 seems to have taken care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant