Adjoint cleanup #1588
Merged
Adjoint cleanup #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the whitespace changes will complicate rebasing and merging other pending changes to the Python code. Is there something easier than the procedure suggested in #662? (What Python formatting tool did you use?) |
|
ianwilliamson
force-pushed
the
adjoint-cleanup
branch
from
a4c29fc to
0dafbc0
Compare
|
It would be better to have a separate PR with just the |
ianwilliamson
force-pushed
the
adjoint-cleanup
branch
from
0dafbc0 to
3bc87f3
Compare
Done in #1590. |
ianwilliamson
force-pushed
the
adjoint-cleanup
branch
4 times, most recently
from
04649c2 to
ddb627d
Compare
ianwilliamson
force-pushed
the
adjoint-cleanup
branch
from
d09d8c7 to
2d55ad5
Compare
|
I think this PR is good to go. These changes are relatively minor code health related things that should (hopefully) be uncontroversial. Let me know if there is any additional feedback. |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Correct spelling errors, fix minor bugs / typos, remove unused imports * Make `forward` attribute of EigenmodeCoefficient consistent with constructor arg * Fix typo in docstring and fix incorrect type hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bases off of #1586 to clean up the adjoint module code by:
Applying formatting to the Python code to make it more readable(Moved to Apply yapf tomeep.adjoint.*#1590)ObjectiveQuantityclassreturnstatements at the end of__init__methodsIn a subsequent PR I will propose a fix for #1585.