Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic DFT decimation for band-limited sources #1731

Closed
stevengj opened this issue Aug 12, 2021 · 0 comments · Fixed by #1732
Closed

automatic DFT decimation for band-limited sources #1731

stevengj opened this issue Aug 12, 2021 · 0 comments · Fixed by #1732

Comments

@stevengj
Copy link
Collaborator

stevengj commented Aug 12, 2021

Now that we have the decimation option (#1678) and it seems to be working well, it would be good to make this the default. In particular, whenever we have a known bandlimited source (e.g. a gaussian, where we set the bandwidth as e.g. a tail of 1e-7), we can apply the formula from that issue to set a default decimation factor for any DFT accumulation.

For an API, I'm thinking of a default decimation factor of decimation=0, which will mean "use the automatic decimation if possible, otherwise set decimation=1". That way, the user can still override the DFT decimation by setting it to a positive value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant