Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_mpb.py fails with LAPACK 3.10.0 #1785

Closed
ahoenselaar opened this issue Oct 12, 2021 · 2 comments · Fixed by #1860
Closed

test_mpb.py fails with LAPACK 3.10.0 #1785

ahoenselaar opened this issue Oct 12, 2021 · 2 comments · Fixed by #1860

Comments

@ahoenselaar
Copy link
Contributor

TestModeSolver.test_compute_field_energy fails because expected_fp and the actual data have opposite signs. The D field data also has opposite sign.
The tests in the MPB repo don't seem to encounter the same problem.

@stevengj
Copy link
Collaborator

There is an arbitrary phase choice in the LAPACK eigensolver (which affects MPB), so it's possible that from one LAPACK version to the next we get a different sign out of the eigenmode fields in MPB.

(Though I thought we try to canonicalize the phase to eliminate such arbitrariness?)

@ahoenselaar
Copy link
Contributor Author

Is the proposed fix then to update the assertions in the test to account for the arbitrary phase choice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants