Dft slice #259
Merged
Dft slice #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to test new array functionality; removed 'where' argument from output_dft routines and get_eigenmode_coefficient
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* new branch for dft_slice routines * added get_dft_array routines; updated libmeepgeom/dft-fields unit test to test new array functionality; removed 'where' argument from output_dft routines and get_eigenmode_coefficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Add
fields::get_dft_array(...)routines fordft_{flux, force, near2far, fields}classes.--Update
libmeepgeom/dft-fieldsunit test to test new dft array functionality.--Added
wheredata field todft_{flux, force, near2far, fields}.When one of these classes is created by a constructor taking avolume_list, the internally-storedwherefield is the union of all volumes in the list.--Added
normal_directionfield todft_flux.Set toNO_DIRECTIONif thedft_fluxis created by a constructor taking avolume_list.--Remove
wherearguments todft_outputroutines.--Remove
whereandd(normal direction) arguments toget_eigenmode_coefficients. The volume and normal direction are now taken from thedft_fluxinput parameter. If the normal direction of thedft_fluxisNO_DIRECTIONthen a runtime error is generated.