Get source amplitude from hdf5 file #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create `add_volume_source` that takes array and size * Error checking for real and imag dims sizes * Print name of missing dataset on error * Base linear interpolation on `where_` instead of geometry_lattice * Don't need to link with libctlgeom
|
Updates:
|
Closed
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Basic amplitude file func working * Add linear_interpolate to meep.hpp to avoid redundancy * libmeep doesn't need libmeepgeom * Add namespace to linear_interpolate * Use LDADD for all C++ tests * Link libmeep.so with libctlgeom.so * Remove superfluous changes * Free memory after amp func is done with hdf5 data. * Updates after review * Create `add_volume_source` that takes array and size * Error checking for real and imag dims sizes * Print name of missing dataset on error * Base linear interpolation on `where_` instead of geometry_lattice * Don't need to link with libctlgeom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372
linear_interpolatetolibmeepto avoid multiple definitions, and to use it insources.cpp. The definition is currently infields.cpp, but there might be a better place for it.libmeep.sowithlibctlgeom.soso thatsrc/sources.cpp:amp_file_funccan accessgeometry_latticeandgeometry_center.mp.Source.add_volume_sourcethat creates an amplitude function that reads from an hdf5 file. It expects both a.reand.imdataset.1+1j, then runs the same simulation that gets the amplitude from an hdf5 file of all ones (2, 10x10 datasets for real and imaginary), and compares a field point. A more thorough test is needed (Ardavan mentioned a ray tracing example).@stevengj @oskooi