Add guile API for get-eigenmode-coefficients #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Add get-eigenmode-coefficients to scheme API * Add support for kpoint functions * Return kpoints from get-eigenmode-coefficients * Remove extra define
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coeffsandvgrpusing guile arrays, which allow me to get a C pointer to the data. Themode-coeffs.ctltest works, but I'm not sure if the arrays are guaranteed to be contiguous. The docs say they may not be contiguous if you perform any slicing, so I'm assuming that means a newly-created array is contiguous.get-eigenmode-coefficientsaccepts keyword arguments, with the same defaults as python.add-mode-monitor, andmode-regionas alias offlux-region.mode-coeffs.ctlis the same aspython/tests/mode_coeffs.py. Since the guile interface doesn't really have a test suite, we can replace that with an example similar topython/examples/mode-decomposition.py.I checked the manual to make sure the guile features I'm using are present in versions >= 1.8, but I've only tested it on 2.0.11.
@stevengj @oskooi