Add changes requested in issue 490 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Oct 23, 2018
| @@ -1237,7 +1237,9 @@ def modal_volume_in_box(self, box=None, center=None, size=None): | |||
| def solve_cw(self, tol=1e-8, maxiters=10000, L=2): | |||
| if self.fields is None: | |||
| raise RuntimeError('Fields must be initialized before using solve_cw') | |||
| return self.fields.solve_cw(tol, maxiters, L) | |||
| res = self.fields.solve_cw(tol, maxiters, L) | |||
| self._evaluate_dft_objects() | |||
There was a problem hiding this comment.
This line needs to go before solve_cw, I think, so that the update_dfts() call in solve_cw will take effect?
There was a problem hiding this comment.
Fixed. This is green.
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Add changes requested in issue 490 * evaluate dft objects before solve_cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #490.
@stevengj @oskooi