Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array-slice interpolation #759

Closed
stevengj opened this issue Mar 8, 2019 · 1 comment · Fixed by #1456
Closed

array-slice interpolation #759

stevengj opened this issue Mar 8, 2019 · 1 comment · Fixed by #1456

Comments

@stevengj
Copy link
Collaborator

stevengj commented Mar 8, 2019

Currently array_slice.cpp sets snap_empty_dims=true when calling loop_in_chunks. This means that slice locations are "rounded" to the nearest pixel rather than being interpolated. (See also the discussion in #661.)

It would be nice to do proper interpolation here:

  1. In array_slice.cpp, pass snap_empty_dims=false when calling loop_in_chunks

  2. Include the interpolation weights in the fields stored in the slice array.

  3. Call collapse_empty_dimensions from dft.cpp to collapse empty dimensions to the interpolated result.

@stevengj
Copy link
Collaborator Author

Once this is resolved we can fix the get_array_metadata function, which now has a hard time because DFT slices and array slices are different so the same metadata can't necessarily be correct for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant