-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
displaying the progress status and total time of near2far calculations in output #849
Comments
i.e. we'd add something like Lines 43 to 54 in a06587c
farfield_lowlevel here
(We can use the same ( |
One thing we might think about is having a callback function for progress instead of a hard-coded printf. That is, you would call something like This would allow us to potentially call something like the progressbar2 package in Python (or tqdm or similar). |
The total time spent computing the far fields during the call to For example, python/examples/binary_grating_n2f.py has three separate calls to
|
In certain situations involving a large number of far-field points, the
near2far
routinesget_farfields
andoutput_farfields
can comprise the majority of the wall-clock time (e.g., the tutorial example in #845). Currently, the progress status of thenear2far
calculation is not included in the output. Unlike the progress status for the time-stepping (i.e.,on time step 4467 (time=55.8375), 0.0549067 s/step
) which provides an approximate insight into its expected completion, no such information is available fornear2far
calculations. In fact, there is no mention at all in the output that the far-fields are being computed. It would be useful to include some indication of thenear2far
progress in the output. This information could also facilitate with debugging to improve performance.The text was updated successfully, but these errors were encountered: