Strings are not always single quoted

[alanliang]

var a = {name: "Steve&Jobs"};
rison.encode(a)

Actual:

"(name:Steve&Jobs)"

Expected: String with quotes.

"(name:'Steve&Jobs')"

However, quotes are inserted when there is a space in the string:

var b = {name: "Steve&Jobs "};
rison.encode(b)

Actual and Expected:

"(name:'Steve&Jobs ')"

The problem is the encoded value is placed in a URI, there will be trouble decoding it since & will be interfering.

Any reason why we don't quote in certain cases?

string: function (x) {
                if (x == '')
                    return "''";

                if (rison.id_ok.test(x))
                    return x;

[Nanonid]

This is an excellent candidate for a API validation test. #10

[funseiki]

I'm running into this as well. Any plans for a fix as of yet?

[5thHorsem4n]

I found a work around for this issue.
Instead of encodeURIComponent the entire string just encode &. The browser in my case is taking care of the rest.

In my testing it was limited to if there was another property after the string.

Here are my tests:

 var encodeUriText = {
        name: encodeURIComponent(".Black & White"),
        z:1
    };

    var currentWorkAround = {
        name: ".Black & White".replace("&","%26"),
        z:1
    };

    var encodeUriTextExpected = "(name:'.Black%20%26%20White',z:1)";
    var currentEncodeUriTextEncoding = "(name:.Black%20%26%20White,z:1))";

    it('current behavior', function () {


        //Act
        var testObjEncoded = rison.encode(encodeUriText);

        //Assert
        expect(testObjEncoded).to.deep.equal(encodeUriTextExpected);
        expect(testObjEncoded).to.deep.equal(currentEncodeUriTextEncoding);

    });

    it('current work around', function () {


        //Act
        var currentWorkAroundEncoded = rison.encode(currentWorkAround);

        //Assert
        expect(currentWorkAroundEncoded).to.deep.equal("(name:'.Black %26 White',z:1)");

    });

    it('decoding encodeUriTextExpected', function () {


        //Act
        var decoded = rison.decode(encodeUriTextExpected);

        //Assert
        expect(decoded).to.deep.equal(encodeUriText);

    });


    it('current error while decoding string', function () {


        //Act
        var decoded = rison.decode(currentEncodeUriTextEncoding);

        //Assert
        expect(decoded).to.deep.equal(encodeUriText);

    });
    it('seems to work fine', function () {


        //Act
        var decoded = rison.decode("(name:'.Black%20%26%20White')");

        //Assert
        expect(decoded).to.deep.equal({name:'.Black%20%26%20White'});

    });`