Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on PHP 8.1 #1274

Closed
osma opened this issue Feb 16, 2022 · 1 comment · Fixed by #1385
Closed

Tests fail on PHP 8.1 #1274

osma opened this issue Feb 16, 2022 · 1 comment · Fixed by #1385
Labels
Milestone

Comments

@osma
Copy link
Member

osma commented Feb 16, 2022

At which URL did you encounter the problem?

Any recent CI jobs, e.g. https://github.com/NatLibFi/Skosmos/runs/5185995020?check_suite_focus=true

What steps will reproduce the problem?

  1. Try to run unit tests on PHP 8.1

What is the expected output? What do you see instead?

Expected: Tests should pass.
Reality: "There were 474 errors"

The main culprit seems to be EasyRdf, which isn't yet compatible with PHP 8.1, but there's an open PR which should hopefully fix this before long.

@osma
Copy link
Member Author

osma commented Oct 24, 2022

EasyRdf development seems to have stalled (again), but there is a more up to date fork available which is compatible with PHP 8.1: https://github.com/sweetrdf/easyrdf
We could consider switching to that.

@kouralex kouralex mentioned this issue Nov 3, 2022
4 tasks
@osma osma closed this as completed in #1385 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant