Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you! #1

Open
JingyeL opened this issue Mar 7, 2019 · 1 comment
Open

Thank you! #1

JingyeL opened this issue Mar 7, 2019 · 1 comment

Comments

@JingyeL
Copy link

JingyeL commented Mar 7, 2019

Just to say a big thank you!
I deployed and test this function smoothly.

3 minor issues

  1. The lambda function must be deployed to the same region as where your S3 bucket is. S3 bucket is 'global' although when it was created there is a 'home' region it belongs to. After I change to deploy the lambda function in that region, it works.
  2. file extension '.pdf' is appended to existing file name so 'document.docx.pdf'. It would be nice to have '.docx' removed.
    3 Font type, it doesn't support Chinese characters. I suppose this is down to 'docx-wasm' library.
@JasonHarrop
Copy link
Contributor

Thanks for your note. Supporting Chinese characters is a matter of including suitable fonts. We can do this, but have left them out of the default install to reduce the package size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants