From 4408b991aaefcad71acf2985fc61f54091403bf6 Mon Sep 17 00:00:00 2001 From: Hugo Mercado Date: Tue, 22 May 2018 20:17:28 -0500 Subject: [PATCH] updated swagger core and swagger parser versions, also added tests to confirm that issue #7980 is solved with these changes. --- .../java/io/swagger/codegen/CodegenTest.java | 9 ++++++++ .../src/test/resources/2_0/petstore.yaml | 23 +++++++++++++++++++ pom.xml | 4 ++-- 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java b/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java index 0fae4eac112..245f977da7f 100644 --- a/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java +++ b/modules/swagger-codegen/src/test/java/io/swagger/codegen/CodegenTest.java @@ -1,6 +1,7 @@ package io.swagger.codegen; import io.swagger.models.Model; +import io.swagger.models.ModelImpl; import io.swagger.models.Operation; import io.swagger.models.Swagger; import io.swagger.models.properties.Property; @@ -431,4 +432,12 @@ public void deprecatedParamTest() { Assert.assertTrue(op.isDeprecated); } + + @Test(description = "https://github.com/swagger-api/swagger-codegen/issues/7980") + public void testPattern() throws Exception { + final Swagger swagger = parseAndPrepareSwagger("src/test/resources/2_0/petstore.yaml"); + ModelImpl currency = (ModelImpl) swagger.getDefinitions().get("Currency"); + Assert.assertNotNull(currency); + Assert.assertEquals(currency.getPattern(), "^[A-Z]{3,3}$"); + } } diff --git a/modules/swagger-codegen/src/test/resources/2_0/petstore.yaml b/modules/swagger-codegen/src/test/resources/2_0/petstore.yaml index 7a3a71c9bf0..5bce1436dc1 100644 --- a/modules/swagger-codegen/src/test/resources/2_0/petstore.yaml +++ b/modules/swagger-codegen/src/test/resources/2_0/petstore.yaml @@ -702,6 +702,29 @@ definitions: type: string message: type: string + #issue: https://github.com/swagger-api/swagger-codegen/issues/7980 + Amount: + type: object + description: > + some description + properties: + value: + format: double + type: number + minimum: 0.01 + maximum: 1000000000000000 + description: > + some description + currency: + $ref: '#/definitions/Currency' + required: + - value + - currency + Currency: + type: string + pattern: '^[A-Z]{3,3}$' + description: > + some description externalDocs: description: Find out more about Swagger url: 'http://swagger.io' diff --git a/pom.xml b/pom.xml index a545ff845db..086c74703a9 100644 --- a/pom.xml +++ b/pom.xml @@ -933,10 +933,10 @@ - 1.0.34 + 1.0.36-SNAPSHOT 2.11.1 3.3.0 - 1.5.18 + 1.5.20-SNAPSHOT 2.4 1.2 4.8.1